Improve window move bindings #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep focus on the window being moved
kaykayehnn
force-pushed
the
improve-window-move
branch
from
8c48cbd to
e36770b
Compare
kaykayehnn
force-pushed
the
improve-window-move
branch
from
e36770b to
a2895b1
Compare
|
Whoops, seems like there is already a PR for this #28 😅 I took a look at the original issue (tmux/tmux#1879) and the tmux changelog. This inconsistency is one of the breaking changes introduced in v3.0 so I added a condition to apply the appropriate binding based on which version of tmux we're running in: tmux-pain-control/pain_control.tmux Lines 29 to 39 in a2895b1 I verified this works correctly in versions 3.0a and 2.9 |
Use bc for floating point comparison instead of lexicographic order Replace \d with [0-9] for better compatibility
|
Thank you for this PR. |
belminf
pushed a commit
to belminf/tmux-pain-control
that referenced
this pull request
May 4, 2020
The behavior for this was changed in tmux 3.0 We're adding a flag to keep tmux 2.x behavior. Thanks @kaykayehnn Closes tmux-plugins#30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the window move bindings switch focus from the current window to the one we are swapping with our current window. This makes the bindings somewhat unintuitive.
For example, if I'm in a session with 3 windows and the third one is currently focused:
I would expect that triggering
`prefix + <` (moves current window one position to the left)twice would move window C to the first position:Current behaviour
The first time the binding is triggered it swaps windows C and B, but it moves focus from C to B
The second time it swaps the same windows (B and C), but it focuses window C, which brings us back to the initial position:
New behaviour
This PR changes the bindings to keep focus on the window being moved, which solves the issue